fix(default): Remove undocumented alias of default() #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an alias of the default() method, called 'defaults', that was added to avoid usage of a reserved word (yargs@1bd4375) This isn't actually needed because a method is a fair use of default keywords in javascript.
|
@elas7 unfortunately, this is a breaking change and I bet a few folks have stumbled into using |
|
@elas7 rather than this change, let's either document this alias or document and indicate that this alias is deprecated and will go away in |
|
@elas7 this has landed in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an alias of the
default()method, called 'defaults', that was added to avoid usage ofa reserved word (1bd4375)
This isn't actually needed because a method name is a fair use of reserved keywords in Javascript.