Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yargs is no longer lighweight. #468

Closed
osher opened this issue Apr 6, 2016 · 2 comments · Fixed by #474
Closed

Yargs is no longer lighweight. #468

osher opened this issue Apr 6, 2016 · 2 comments · Fixed by #474

Comments

@osher
Copy link
Contributor

osher commented Apr 6, 2016

It started as lightweight, and was very cool (and still is).
But it's not lightweight.

Once installed, the size of a package including all its dependencies:

Yargs@4.4.0:

  • 990Kb
  • (418 files, 123 folders)

nomnom@1.8.1:

  • 115K
  • (35 files, 9 folders)

Commander@2.9.0:

  • 40Kb
  • (11 files, 2 folders)

ahm... :(

I was advocating for it, and was corrected by my listeners
It's not lightweight. It's ritch with features.

Since I don't think we should drop functionality, I suggest to correct the misleading description...

@bcoe
Copy link
Member

bcoe commented Apr 6, 2016

@osher I'm for this, I also think we should look at if we're checking in anything we can avoid -- we have quite a few dependencies so it does add up unfortunately.

@nexdrew
Copy link
Member

nexdrew commented Apr 6, 2016

@bcoe It looks like the following dependencies could stand some cleanup:

# cliui@3.1.2
./cliui/test

# read-pkg-up@1.0.1 > read-pkg@1.1.0 > normalize-package-data@2.3.5 > hosted-git-info@2.1.4
./hosted-git-info/test
./hosted-git-info/test/lib

# read-pkg-up@1.0.1 > read-pkg@1.1.0 > normalize-package-data@2.3.5
./normalize-package-data/test
./normalize-package-data/test/fixtures

# read-pkg-up@1.0.1 > read-pkg@1.1.0 > normalize-package-data@2.3.5 > semver@5.1.0
./semver/test

# yargs-parser@2.2.0
./yargs-parser/test
./yargs-parser/test/fixtures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants