middleware applied before validation is called multiple times

[josephperrott]

When a middleware is defined to be run before validation, it appears that it is called multiple times.

See example in this stackblitz by running node index.js not-test test in the terminal.

It looks like this has been brought up before in different ways and solved, but it appears that it is till occuring.

[shadowspawn]

Thanks for the example code. In case it becomes unavailable:

const yargs = require('yargs');

const CommandModule = {
  builder: (argv) => {
    argv.middleware(async () => {
      console.log('command middleware');
    }, true);
  },
  handler: () => {
    console.log('command');
  },
  command: 'test',
};

function buildParser(localYargs) {
  return localYargs.command(CommandModule);
}

yargs()
  .middleware(async () => {
    console.log('global middleware');
  }, true)
  .command('not-test', false, buildParser)
  .parse(process.argv.slice(2), () => {
    console.log('complete');
  });

~/projects/node-t7j85c
❯ node index.js not-test test
global middleware
command middleware
command
global middleware
command middleware
complete

[shadowspawn]

Related: #1802 #1966 #1978

[shadowspawn]

(Reproduced with example code using Yargs v17.7.2.)