Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zsh completion is now installable system-wide #1856

Merged
merged 1 commit into from Feb 13, 2021
Merged

Conversation

gardenappl
Copy link
Contributor

I manage an AUR package for my own node CLI tool, so I want to be able to install Bash/Zsh completions system-wide.

Bash completion works fine when I put it in /usr/share/bash-completion/completions/<app name>. But when I try to put the Zsh completion into /usr/share/zsh/site-functions/_<app name> it does not work at all.

This is fixed by adding #compdef _<app name> at the top of the completion file.

@bcoe bcoe merged commit d731f9f into yargs:master Feb 13, 2021
@bcoe
Copy link
Member

bcoe commented Feb 13, 2021

@gardenappl thank you for the contribution 👏

I don't use zsh, so will trust you on this one 😄

Releases are slightly held up on a refactor right now, but I an release a candidate tag for you to test out on npm.

@gardenappl
Copy link
Contributor Author

Releases are slightly held up on a refactor right now, but I an release a candidate tag for you to test out on npm.

Nah, right now I'm pointing to my fork's GitHub repo as the dependency and that works well enough for me. The thing is, I'm also relying on #1855 (and I guess that one will take more effort to review)

@bcoe
Copy link
Member

bcoe commented Feb 15, 2021

@gardenappl please try npm i yargs@17.0.0-candidate.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants