Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint v7 is incompatible with node 8 and eslint-plugin-import #1669

Closed
mleguen opened this issue Jun 3, 2020 · 1 comment · Fixed by #1673
Closed

Eslint v7 is incompatible with node 8 and eslint-plugin-import #1669

mleguen opened this issue Jun 3, 2020 · 1 comment · Fixed by #1673
Labels

Comments

@mleguen
Copy link
Member

mleguen commented Jun 3, 2020

@bcoe Due to #1656, we have warnings now in npm install as eslint-plugin-import is not yet compatible with eslint v7:

npm WARN eslint-plugin-react@7.14.3 requires a peer of eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN eslint-plugin-import@2.20.1 requires a peer of eslint@2.x - 6.x but none is installed. You must install peer dependencies yourself.

Nothing seems to be broken in linting however.

Upgrading to eslint-plugin-import@2.20.2 does not change anything.

@mleguen mleguen added the bug label Jun 3, 2020
@mleguen mleguen changed the title Eslint v7 is incompatible with eslint-plugin-import Eslint v7 is incompatible with node 8 and eslint-plugin-import Jun 6, 2020
@mleguen
Copy link
Member Author

mleguen commented Jun 6, 2020

Eslint 7.2.0 no longer supports node 8, so our tests on master are now failing on an optional catch binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant