Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): Japanese translation phrasing #1619

Merged
merged 3 commits into from Apr 12, 2020
Merged

fix(i18n): Japanese translation phrasing #1619

merged 3 commits into from Apr 12, 2020

Conversation

hogashi
Copy link
Contributor

@hogashi hogashi commented Apr 10, 2020

Fixed 3 issues of Japanese translation described in #1617

@mleguen
Copy link
Member

mleguen commented Apr 10, 2020

Thank you @hogashi .

I add this review to my TODO, but I'm afraid I won't be able to have some time for it before next week.

@hogashi
Copy link
Contributor Author

hogashi commented Apr 10, 2020

@mleguen Of course that's OK! Don't hurry and review it whenever you like 👍

@bcoe bcoe changed the title fix: Japanese translation phrasing fix(i18n): Japanese translation phrasing Apr 12, 2020
@bcoe bcoe merged commit 0894175 into yargs:master Apr 12, 2020
@bcoe
Copy link
Member

bcoe commented Apr 12, 2020

@hogashi 👍 contribution is much appreciated.

@hogashi
Copy link
Contributor Author

hogashi commented Apr 12, 2020

Thank you, @bcoe ! I'm glad to contribute to this awesome project ⭐ / Would you take care of the issue #1617, or may I close it right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants