Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yargs): correct support of bundled electron apps #1554

Merged
merged 1 commit into from Feb 20, 2020
Merged

fix(yargs): correct support of bundled electron apps #1554

merged 1 commit into from Feb 20, 2020

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Feb 12, 2020 •
edited by bcoe

Fix the first attempt at detecting bundled electron apps, whose arguments start at process.argv[1], not process.argv[2], by handling process.versions.electron and process.defaultApp.

Fixes: #685

@mleguen mleguen requested a review from bcoe February 12, 2020 11:43
bcoe
bcoe approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for seeing this work over the finish line.

@bcoe bcoe changed the title fix(yargs): correct support of bundled electron apps fix(electron): correct support of bundled electron apps Feb 16, 2020
@mleguen mleguen force-pushed the 685-fix-bundled-electron-app-support branch from cc7df8d to e2e17c1 Compare February 20, 2020 09:46
@mleguen mleguen force-pushed the 685-fix-bundled-electron-app-support branch from e2e17c1 to 15c0c3c Compare February 20, 2020 09:49
@mleguen mleguen changed the title fix(electron): correct support of bundled electron apps fix(yargs): correct support of bundled electron apps Feb 20, 2020
@mleguen mleguen merged commit a0b61ac into master Feb 20, 2020
@mleguen mleguen deleted the 685-fix-bundled-electron-app-support branch February 20, 2020 10:50
This was referenced Nov 25, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong $0 in bundled electron app
2 participants
@mleguen @bcoe