Use process.defaultApp to detect built electron app #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove only the first element of process.argv
bcoe
approved these changes
Jan 30, 2020
|
@mleguen friendly reminder to make sure you use conventional commits when you merge, or else stuff doesn't show up in the next release, I went ahead and amended. |
bcoe
pushed a commit
that referenced
this pull request
Feb 5, 2020
Use process.defaultApp to detect built electron app
|
@bcoe Oops! Sorry and thanks. Would you have a link to some doc about the requested commit syntax (is it the same as the one used by nest.js?) for me to do it as expected next time? |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If process.defaultApp is false (for built electron app), remove only the first element of process.argv (the app binary) and not the two first elements (node + the app script).
See electron/electron#4690 (comment) for mor info.
Solve part of #685