Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): takes negated flags into account when boolean-negation is set #1509

Merged

Conversation

mleguen
Copy link
Member

@mleguen mleguen commented Dec 4, 2019

Closes #1431

When boolean-negation is set:

  • completes --no-flag when flag defaults to true
  • avoids repeating flags whose negated counterpart is already present

@mleguen
Copy link
Member Author

mleguen commented Dec 4, 2019

Warning : either this PR or #1507 will need some conflict-handling before merging, as both impact the same lines in completion.js.

EDIT: fixed issue reference

@bcoe bcoe added the blocked label Dec 6, 2019
@bcoe
Copy link
Member

bcoe commented Dec 6, 2019

👍 let's hold off on landing until we have a plan. Perhaps you could make a PR against this PR, for #1508 rather than us having both PRs open at the same time.

@mleguen mleguen force-pushed the feature/1431-complete-no-flags-when-boolean-negation-is-set branch from ea3fe04 to 822a200 Compare December 18, 2019 09:40
@mleguen
Copy link
Member Author

mleguen commented Dec 18, 2019

I wronlgy mentionned #1508, but is #1507 which should conflict with this PR.

Instead of doing something complicated, let's merge #1507 first (it will need reviewing first), and I will then rebase this PR.

@bcoe
Copy link
Member

bcoe commented Jan 2, 2020

@mleguen bother you to rebase?

@bcoe bcoe changed the title feature(completion): takes negated flags into account when boolean-negation is set feat(completion): takes negated flags into account when boolean-negation is set Jan 2, 2020
@mleguen
Copy link
Member Author

mleguen commented Jan 2, 2020

@bcoe I should have some time to do it next week

@mleguen mleguen force-pushed the feature/1431-complete-no-flags-when-boolean-negation-is-set branch from 822a200 to a00aa57 Compare January 8, 2020 10:00
@mleguen
Copy link
Member Author

mleguen commented Jan 8, 2020

@bcoe done!

@bcoe bcoe removed the blocked label Jan 9, 2020
@bcoe bcoe merged commit 4e0c5b0 into master Jan 9, 2020
bcoe pushed a commit that referenced this pull request Jan 9, 2020
@bcoe bcoe deleted the feature/1431-complete-no-flags-when-boolean-negation-is-set branch January 9, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completions should suggest --no-* flags when appropriate
2 participants