fix getCompletion() no longer working for options #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2019 18:02
As completion needs parsed.aliases to complete options
bcoe
approved these changes
Nov 27, 2019
bcoe
deleted the
fix/1434-get-completion-no-longer-working-for-options
branch
|
@mleguen thanks for the patch 👌 |
|
@mleguen this should be out the door in |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCompletion() throws when completing an option, as it needs
parsed.aliases, which is lost (unfreezed) when calling.parse()with arguments.See #1434
This is a side effect of fixing
.parse()to be able to call it several times, a few months ago.This PR provides
parsedto completion before unfreezing it.