Make strict() work with options containing hyphens

[andrewdotn]

Fixes #1039 #1171 #1236 #1325

[bcoe]

prior to your fix would the following also fail?

yargs('--foo-bar')
        .option('foo-bar', {describe: 'foo bar option'})
        .strict()
        .fail((msg) => {
          return done()
        })
        .argv

[andrewdotn]

I’m not sure why you’re asking about that, but both before and after my fix, with that code, argv returns {'foo-bar': true, 'fooBar': true} instead of failing.

[bcoe]

thanks for the contribution @andrewdotn, I think we should add a couple more test cases for the happy paths, but this looks like it's on the right track.

[bcoe]

let's call this, isValidAndNotNewAlias, just to match naming.

[andrewdotn]

Hello @bcoe, I’ve renamed that method and added some more tests. Anything more to get this merged?

[andrewdotn]

@bcoe Thanks! The Fixes: in the PR description seems to have done the auto-close-on-commit thing for only the first issue, so you may want to close #1171 #1236 #1325 as well.

[bcoe]

@andrewdotn could you please give the following a try:

npm i yargs@next

And let me know if everything is working as expected?

[andrewdotn]

@bcoe Yup, confirmed working, thanks!

Test file:

const yargs = require('yargs');

const argv = yargs
.strict()
.argv;

console.log(argv);

Before:

$ node foo.js --foo-bar
{ _: [], 'foo-bar': true, fooBar: true, '$0': 'foo.js' }

yargs@next:

h$ node foo.js --foo-bar
Options:
--help     Show help                                                 [boolean]
--version  Show version number                                       [boolean]

Unknown arguments: foo-bar, fooBar
Returned 1.

[bcoe]

@andrewdotn sorry that it took a while to get a release out the door; this work should now be available in yargs@14.2.0.

Let me know if you bump into any issues, and thank you for your contribution!