fix: detect zsh when zsh isnt run as a login prompt

[forivall]

I don't run zsh as a login prompt, and I haven't chsh'd from bash to zsh, and so yargs was still giving me the bash completion when running it inside of zsh.

[mleguen]

You must use parenthesis when mixing && and || in the same expression, to respect coding standards.

[bcoe]

@forivall thanks for the contribution 👍 I don't use zsh personally, so it's great to have someone kick the tires of the completion logic.

Like @mleguen says, tests are failing because of linting, you might be able to simply run:

./node_modules/.bin/standard --fix

If you don't get around to fixing the linting, I'll work on landing this soon myself.

[forivall]

Whoops, yeah, I forgot about that comment. I'll get to it tomorrow. Thanks!! ~ Emily Klassen

…

On Mon., Aug. 19, 2019, 3:26 p.m. Benjamin E. Coe, ***@***.***> wrote: @forivall <https://github.com/forivall> thanks for the contribution 👍 I don't use zsh personally, so it's great to have someone kick the tires of the completion logic. Like @mleguen <https://github.com/mleguen> says, tests are failing because of linting, you might be able to simply run: ./node_modules/.bin/standard --fix If you don't get around to fixing the linting, I'll work on landing this soon myself. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1395?email_source=notifications&email_token=AAFZTDCYYXTTOPYDCUCHUE3QFMM2RA5CNFSM4IKYNSK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UPIOA#issuecomment-522777656>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFZTDHK47ZE5PWPBF64RUDQFMM2RANCNFSM4IKYNSKQ> .

[forivall]

the --fix flag with standard didn't auto-fix. So i added the parens manually, and now it passes the standard check.

[bcoe]

@forivall thank you for the contribution 😄

[bcoe]

@forivall this is now released in yargs@14.2.0.