Don't set stateful completionCommand in showCompletionScript #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronhunter
force-pushed
the
fix-completion-script
branch
from
6bacc14
to
ae21e63
Compare
|
@cameronhunter agreed that it seems weird that |
|
The side-effect was two completion scripts being logged. |
|
@cameronhunter I'm definitely a bit confused by this emergent bug 😝, but I've seen stranger things. |
|
@cameronhunter could you please try: It should have your fix 👍 |
|
@cameronhunter this is now released in |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to write a test case for this but couldn't find one that reproduced the issue. I think the issue only exists when using
yargsas a singleton. The issue is that two completion scripts are logged, one from the explicit call toshowCompletionScriptand the second fromyargs.js#1108.