feat: Inline code to detect current locale from environment #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates half the dependencies of yargs without any change in functionality. The extra dependencies were used by the os-locale module to execute detection utilities, this execution functionality was always disabled by yargs. Fixes yargs#1354
coreyfarrell
commented
Jun 8, 2019
| self.locale(osLocale.sync({ spawn: false })) | ||
| const { env } = process | ||
| const locale = env.LC_ALL || env.LC_MESSAGES || env.LANG || env.LANGUAGE || 'en_US' | ||
| self.locale(locale.replace(/[.:].*/, '')) |
There was a problem hiding this comment.
In theory we the try / catch block is no longer needed but the way os-locale was used I think it was impossible for it to throw, therefore I assume that it's possible for self.locale() to cause an exception.
|
@coreyfarrell incredible work, thanks for doing this. |
|
@coreyfarrell when you have a sec try |
|
It works for my (admittedly simple) use case, |
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates half the dependencies of yargs without any change in
functionality. The extra dependencies were used by the os-locale module
to execute detection utilities, this execution functionality was always
disabled by yargs.
Fixes #1354