Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translation not working when using __ with a single parameter #1183

Merged
merged 2 commits into from Aug 11, 2018

Conversation

jjoselv
Copy link
Contributor

@jjoselv jjoselv commented Jul 17, 2018

Closes #1101

@nexdrew
Copy link
Member

nexdrew commented Jul 17, 2018

@jjoselv Good find! I verified locally that this one i18n message was not being properly translated and that your change fixes it. I then wrote a test for it and pushed it to your fork, which added it to this PR.

On top of this, would you be able to provide any proper translations of the i18n string in other languages? If so, you could add those translations to this PR, if you want. Otherwise, we can worry about that later.

Thanks again!

@jjoselv
Copy link
Contributor Author

jjoselv commented Jul 17, 2018

@nexdrew I won't be able to work on that today, so it would be better to leave it for later, but will surely do! And thanks for reviewing the commit! 👍

@jjoselv
Copy link
Contributor Author

jjoselv commented Jul 18, 2018

If all is well, can this PR be merged by someone please?

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this.

@bcoe bcoe merged commit f449aea into yargs:master Aug 11, 2018
@bcoe
Copy link
Member

bcoe commented Oct 6, 2018

@jjoselv this should now be fixed \o/ please try npm i yargs@next; if the release is looking good, I will promote it next week.

@jjoselv
Copy link
Contributor Author

jjoselv commented Oct 8, 2018

@bcoe It works. Good to go. I'll update the i18n files at some point in time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants