Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 'false' value is no longer set when boolean flag is not passed #1104

Merged
merged 1 commit into from Apr 7, 2018

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Apr 4, 2018

BREAKING CHANGE: yargs-parser does not populate 'false' when boolean flag is not passed

…e for unset boolean

BREAKING CHANGE: yargs-parser does not populate 'false' when boolean flag is not passed
@bcoe bcoe merged commit d4705f4 into master Apr 7, 2018
@bcoe bcoe deleted the undefined-boolean branch April 7, 2018 19:42
@bcoe
Copy link
Member Author

bcoe commented Apr 7, 2018

@evocateur I'm going to work on having a patched version of yargs out soonish with this functionality.

@evocateur
Copy link
Contributor

Great!

@bcoe
Copy link
Member Author

bcoe commented Jun 26, 2018

@evocateur sorry this took a little while to release ... when you have a couple seconds mind trying npm i yargs@next and making sure this works properly with lerna, I'll promote the release soon.

@evocateur
Copy link
Contributor

evocateur commented Jun 26, 2018 via email

eliperelman pushed a commit to neutrinojs/neutrino that referenced this pull request Jul 2, 2018
This Pull Request updates dependency [yargs](https://github.com/yargs/yargs) from `^11.0.0` to `^12.0.0`



<details>
<summary>Release Notes</summary>

### [`v12.0.1`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1201httpsgithubcomyargsyargscomparev1200v1201-2018-06-29)
[Compare Source](yargs/yargs@v12.0.0...v12.0.1)
#### [12.0.1](yargs/yargs@v12.0.0...v12.0.1) (2018-06-29)

---

### [`v12.0.0`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1200httpsgithubcomyargsyargscomparev1110v1200-2018-06-26)
[Compare Source](yargs/yargs@v11.1.0...v12.0.0)
##### Bug Fixes

* .argv and .parse() now invoke identical code path ([#&#8203;1126](`yargs/yargs#1126)) ([f13ebf4](yargs/yargs@f13ebf4))
* remove the trailing white spaces from the help output ([#&#8203;1090](`yargs/yargs#1090)) ([3f0746c](yargs/yargs@3f0746c))
* **completion:** Avoid default command and recommendations during completion ([#&#8203;1123](`yargs/yargs#1123)) ([036e7c5](yargs/yargs@036e7c5))
##### Chores

* test Node.js 6, 8 and 10 ([#&#8203;1160](`yargs/yargs#1160)) ([84f9d2b](yargs/yargs@84f9d2b))
* upgrade to version of yargs-parser that does not populate value for unset boolean ([#&#8203;1104](`yargs/yargs#1104)) ([d4705f4](yargs/yargs@d4705f4))
##### Features

* add support for global middleware, useful for shared tasks like metrics ([#&#8203;1119](`yargs/yargs#1119)) ([9d71ac7](yargs/yargs@9d71ac7))
* allow setting scriptName $0 ([#&#8203;1143](`yargs/yargs#1143)) ([a2f2eae](yargs/yargs@a2f2eae))
* remove `setPlaceholderKeys` ([#&#8203;1105](`yargs/yargs#1105)) ([6ee2c82](yargs/yargs@6ee2c82))
##### BREAKING CHANGES

* Options absent from `argv` (not set via CLI argument) are now absent from the parsed result object rather than being set with `undefined`
* drop Node 4 from testing matrix, such that we'll gradually start drifting away from supporting Node 4.
* yargs-parser does not populate 'false' when boolean flag is not passed
* tests that assert against help output will need to be updated

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants