Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trailing white spaces from the help output #1090

Merged
merged 3 commits into from Apr 7, 2018

Conversation

faressoft
Copy link
Contributor

@faressoft faressoft commented Mar 19, 2018

  • e5deaf7 Add tests
  • b07abdc Remove the trailing white spaces from the help output
  • 6a13023 Print a new line between the help and the error on fail if showHelpOnFail is enabled

@bcoe bcoe merged commit 3f0746c into yargs:master Apr 7, 2018
@bcoe
Copy link
Member

bcoe commented Apr 7, 2018

@faressoft thank you for the contribution 👍 I'll work on having an update out soon.

@bcoe
Copy link
Member

bcoe commented Jun 26, 2018

@faressoft this work is now released to the next tag on npm, when you have a moment, mind running:

npm i yargs@next on your projects, and making sure things behave as expected.

eliperelman pushed a commit to neutrinojs/neutrino that referenced this pull request Jul 2, 2018
This Pull Request updates dependency [yargs](https://github.com/yargs/yargs) from `^11.0.0` to `^12.0.0`



<details>
<summary>Release Notes</summary>

### [`v12.0.1`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1201httpsgithubcomyargsyargscomparev1200v1201-2018-06-29)
[Compare Source](yargs/yargs@v12.0.0...v12.0.1)
#### [12.0.1](yargs/yargs@v12.0.0...v12.0.1) (2018-06-29)

---

### [`v12.0.0`](https://github.com/yargs/yargs/blob/master/CHANGELOG.md#&#8203;1200httpsgithubcomyargsyargscomparev1110v1200-2018-06-26)
[Compare Source](yargs/yargs@v11.1.0...v12.0.0)
##### Bug Fixes

* .argv and .parse() now invoke identical code path ([#&#8203;1126](`yargs/yargs#1126)) ([f13ebf4](yargs/yargs@f13ebf4))
* remove the trailing white spaces from the help output ([#&#8203;1090](`yargs/yargs#1090)) ([3f0746c](yargs/yargs@3f0746c))
* **completion:** Avoid default command and recommendations during completion ([#&#8203;1123](`yargs/yargs#1123)) ([036e7c5](yargs/yargs@036e7c5))
##### Chores

* test Node.js 6, 8 and 10 ([#&#8203;1160](`yargs/yargs#1160)) ([84f9d2b](yargs/yargs@84f9d2b))
* upgrade to version of yargs-parser that does not populate value for unset boolean ([#&#8203;1104](`yargs/yargs#1104)) ([d4705f4](yargs/yargs@d4705f4))
##### Features

* add support for global middleware, useful for shared tasks like metrics ([#&#8203;1119](`yargs/yargs#1119)) ([9d71ac7](yargs/yargs@9d71ac7))
* allow setting scriptName $0 ([#&#8203;1143](`yargs/yargs#1143)) ([a2f2eae](yargs/yargs@a2f2eae))
* remove `setPlaceholderKeys` ([#&#8203;1105](`yargs/yargs#1105)) ([6ee2c82](yargs/yargs@6ee2c82))
##### BREAKING CHANGES

* Options absent from `argv` (not set via CLI argument) are now absent from the parsed result object rather than being set with `undefined`
* drop Node 4 from testing matrix, such that we'll gradually start drifting away from supporting Node 4.
* yargs-parser does not populate 'false' when boolean flag is not passed
* tests that assert against help output will need to be updated

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants