fix: choose correct config directory when require.main does not exist #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the (untested) fix from #1036, which exposed jest's nefarious activity. |
evocateur
changed the title
- Verifies that find-up can deal with non-directory startDir - Removes process.chdir() in integration test helper in favor of opts.cwd
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, it turns out Jest overrides the module-local
requireand neglects to assignrequire.main.filename(jestjs/jest#2150). Maybe I'll even get around to fixing it here, but in the meantime, we can work around it by avoiding the "extra"path.dirname()when it isn't neccessary (becauserequire-main-filenamedefaults toprocess.cwd()).Also, I changed a bunch of function parameters to avoid shadowing
path, it was extremely confusing (and ridiculous to have an innerrequire('path').dirnamewhenconst path = require('path')is already present at the top of the file).