Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set implicit nargs=1 when type=number requiresArg=true #1050

Merged
merged 2 commits into from Jan 20, 2018

Conversation

evocateur
Copy link
Contributor

This fixes the underlying issue in #1015 without breaking nested commands. This PR is built on top of #1049.

evocateur added a commit to evocateur/lerna that referenced this pull request Jan 18, 2018
This is still blocked by yargs/yargs#1050
@evocateur
Copy link
Contributor Author

The mac builds on Travis seem to be non-functional, wonder why yargs even needs that platform in the matrix?

@bcoe bcoe merged commit 2b56812 into yargs:master Jan 20, 2018
@bcoe
Copy link
Member

bcoe commented Jan 20, 2018

@evocateur part of me wonders if we could just use nargs for everything, but going to land this and iterate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants