Fix for requiresArg with number type #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Nov 28, 2017
| @@ -57,7 +57,7 @@ module.exports = function validation (yargs, usage, y18n) { | |||
| // make sure that any args that require an | |||
| // value (--foo=bar), have a value. | |||
| self.missingArgumentValue = function missingArgumentValue (argv) { | |||
| const defaultValues = [true, false, ''] | |||
| const defaultValues = [true, false, '', undefined] | |||
There was a problem hiding this comment.
I find this logic a little weird (it's not your fault, this oddity was already in the codebase). I'm going to do a little bit of investigation when I have some cycles and see if we can figure out a better way to determine if a value has been provided.
This was referenced Jan 17, 2018
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix this issue: #1007