Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalized keys were not enumerable #247

Merged
merged 1 commit into from Feb 29, 2020
Merged

fix: normalized keys were not enumerable #247

merged 1 commit into from Feb 29, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Feb 29, 2020

This was breaking upstream behavior in yargs (and in turn mocha), because the parsed options object is iterated over in yargs and appended to another object:

mocha init <path>

create a client-side Mocha setup at <path>

Positional Arguments
  path                                                       [string] [required]

Other Options
  --help, -h     Show usage information & exit                         [boolean]
  --version, -V  Show version number & exit                            [boolean]

✖ ERROR: Missing required argument: path

@bcoe bcoe merged commit 57119f9 into master Feb 29, 2020
@bcoe bcoe deleted the fix-iteration branch February 29, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant