Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: support keys that collide with object prototypes #234

Merged
merged 1 commit into from Feb 9, 2020
Merged

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Feb 9, 2020

BREAKING CHANGE: objects used during parsing are now created with a null
prototype. There may be some scenarios where this change in behavior
leaks externally.

fixes #228

BREAKING CHANGE: objects used during parsing are now created with a null
prototype. There may be some scenarios where this change in behavior
leaks externally.
@bcoe bcoe requested a review from mleguen February 9, 2020 06:42
@bcoe bcoe merged commit 1587b6d into master Feb 9, 2020
@bcoe bcoe deleted the fix-228 branch February 9, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yargs-parser crashes when passed a --toString option
1 participant