Trailing and leading quote characters are removed

[mefcorvi]

Version 13.1.1

Description

Trailing and leading quote characters are removed from the values. If I want to pass a 'string' as a value I need to triple-quote it as "''string''" or \'''string\''' when I'm specifying that in the shell.

Expected

> require('yargs-parser')([ '--arg', '"option"' ])
{ _: [], arg: '"option"' }

Actual

> require('yargs-parser')([ '--arg', '"option"' ])
{ _: [], arg: 'option' }

This probably relates to #138, #180. Definitely relates to #145 and #153.
I would suggest introducing a new keepQuotes/trimQuotes option to support the all edge cases.

[bcoe]

@mefcorvi in an ideal world my-app --argument \"foo\" would work, might be worth rethinking this bit of the parser.

[juergba]

We should distinguish between parsing a string or array.

• array: require('yargs-parser')([ '--arg', '"option"' ]):
  we should not remove any double quotes => { _: [], arg: '"option"' }
• string: require('yargs-parser')( '--arg "option"' ):
  to be discussed, IMO double quotes should be removed unless:
  • '--arg \"option\"' ?
  • """--arg "option"""" // raw string as in Kotlin ?
  • new configuration option ?

So the change would have to be done in "tokenize-arg-string.js", and not in our parser.

[shadowspawn]

Thanks for the report, and the simple reproduction.

I can no longer reproduce the reported issue. I suspect it was fixed by #407.