From efcc32c2d6b09aba31abfa2db9bd947befe5586b Mon Sep 17 00:00:00 2001 From: Anton Golub Date: Sun, 20 Jun 2021 20:10:11 +0300 Subject: [PATCH] fix(string-utils): detect [0,1] ranged values as numbers (#388) --- lib/string-utils.ts | 2 +- test/string-utils.cjs | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/string-utils.ts b/lib/string-utils.ts index 3f315c17..9c52197d 100644 --- a/lib/string-utils.ts +++ b/lib/string-utils.ts @@ -58,6 +58,6 @@ export function looksLikeNumber (x: null | undefined | number | string): boolean // hexadecimal. if (/^0x[0-9a-f]+$/i.test(x)) return true // don't treat 0123 as a number; as it drops the leading '0'. - if (x.length > 1 && x[0] === '0') return false + if (/^0[^.]/.test(x)) return false return /^[-]?(?:\d+(?:\.\d*)?|\.\d+)(e[-+]?\d+)?$/.test(x) } diff --git a/test/string-utils.cjs b/test/string-utils.cjs index 74d618d4..081dd084 100644 --- a/test/string-utils.cjs +++ b/test/string-utils.cjs @@ -27,8 +27,11 @@ describe('string-utils', function () { it('it detects strings that could be parsed as numbers', () => { strictEqual(looksLikeNumber('3293'), true) strictEqual(looksLikeNumber('0x10'), true) - strictEqual(looksLikeNumber('0x10'), true) + strictEqual(looksLikeNumber('.1'), true) + strictEqual(looksLikeNumber('0.1'), true) + strictEqual(looksLikeNumber('0.10'), true) + strictEqual(looksLikeNumber('00.1'), false) strictEqual(looksLikeNumber('0100'), false) strictEqual(looksLikeNumber('apple'), false) })