fix: should populate "_" when given config with "short-option-groups"…

… false (#179)
yargs · Jun 7, 2019 · 6055974 · 6055974
1 parent 7f33140
commit 6055974
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -177,7 +177,7 @@ function parse (args, opts) {
 
     // -- seperated by space.
     } else if (arg.match(/^--.+/) || (
-      !configuration['short-option-groups'] && arg.match(/^-.+/)
+      !configuration['short-option-groups'] && arg.match(/^-[^-]+/)
     )) {
       key = arg.match(/^--?(.+)/)[1]
 

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -2442,6 +2442,19 @@ describe('yargs-parser', function () {
         result.should.not.have.property('--')
       })
 
+      it('should populate "_" when given config with "short-option-groups" false', function () {
+        var result = parser.detailed([
+          '--', 'foo'
+        ], {
+          configuration: {
+            'short-option-groups': false
+          }
+        })
+        result.argv.should.deep.equal({ '_': ['foo'] })
+        result.argv.should.not.have.property('--')
+        result.newAliases.should.deep.equal({})
+      })
+
       it('should populate the "--" if populate-- is "true"', function () {
         var result = parser([
           '--name=meowmers', 'bare', '-cats', 'woo', 'moxy',