fix: normalized keys were not enumerable (#247)

yargs · Feb 29, 2020 · 57119f9 · 57119f9
1 parent 485d281
commit 57119f9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -465,6 +465,7 @@ function parse (args, opts) {
       const keys = [key].concat(flags.aliases[key] || [])
       keys.forEach(function (key) {
         Object.defineProperty(argvReturn, key, {
+          enumerable: true,
           get () {
             return val
           },

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -342,6 +342,16 @@ describe('yargs-parser', function () {
       a.should.have.property('s').and.deep.equal(expected)
       a.should.have.property('save').and.deep.equal(expected)
     })
+
+    it('should allow normalized keys to be enumerated', () => {
+      var a = parser(['-s', ['', 'tmp', '..', ''].join(path.sep)], {
+        alias: {
+          s: ['save']
+        },
+        normalize: 's'
+      })
+      Object.keys(a).should.include('s')
+    })
   })
 
   describe('alias', function () {