Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember-wormhole failed to render into modal-overlays #261

Open
mhluska opened this issue Aug 29, 2018 · 1 comment
Open

Ember-wormhole failed to render into modal-overlays #261

mhluska opened this issue Aug 29, 2018 · 1 comment

Comments

@mhluska
Copy link

mhluska commented Aug 29, 2018

I'm finding this doesn't work in FastBoot because it's missing the root #modal-overlays element. The instance initializer that is supposed to add it to the DOM doesn't because there is no DOM in fastboot.

As a workaround, I have to add <div id="modal-overlays"></div> to the top of application.hbs.

@Redsandro
Copy link

Thank you @mhluska this fixed my problem.

I can't believe I've added that in index.html and couldn't get it to work and I've been messing around for hours. Turns out index.html is not in the DOM at that point either I guess.

Issue report I wrote before I found yours below.


I've upgraded Ember 2.7 to 3.3, and ember-modal-dialog from 2.0 to 3.0.

Now I'm having the error:

Uncaught Error: ember-wormhole failed to render into '#modal-overlays' because the element is not in the DOM

In Ember 3.3, I'm observing the same error in ember-modal-dialog version 3.0, 2.4, 2.3, 2.2, 2.1 and 2.0.

If I install ember-tether and use that in stead of ember-wormhole by setting tetherTarget=this, I get the error:

There was an error running your app in fastboot. More info about the error:
Error: Assertion Failed: You modified "attachmentClass" twice on <app@component:wallpaper-modal::ember459> in a single render. It was rendered in "component:ember-modal-dialog/-tether-dialog" and modified in "component:ember-modal-dialog/-tether-dialog". This was unreliable and slow in Ember 1.x and is no longer supported. See emberjs/ember.js#13948 for more details.

Looks like a chunk of #260 with a side of #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants