Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way not to include all locales #43

Open
yamadapc opened this issue Jul 3, 2017 · 2 comments
Open

Add a way not to include all locales #43

yamadapc opened this issue Jul 3, 2017 · 2 comments

Comments

@yamadapc
Copy link
Owner

yamadapc commented Jul 3, 2017

There should be a means of not including all locales.

A very simple solution would be to move the logic to lib/core and keep lib/index including all locales, so people would be able to manually require just the logic and the locales they'll use:

import writtenNumber from 'written-number/lib/core';
import writtenNumberEn from 'written-number/lib/i18n/en';
// ...
@leoseccia
Copy link

+1 from me!

@mtkcs
Copy link

mtkcs commented Oct 4, 2019

I made a PR #70 that exposes a standalone version that does not add all the locales. No breaking changes were introduced, please take the time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants