Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter definitions refactor #259

Open
yamadapc opened this issue Apr 7, 2022 · 0 comments
Open

Parameter definitions refactor #259

yamadapc opened this issue Apr 7, 2022 · 0 comments
Labels
Continuous Looper enhancement New feature or request

Comments

@yamadapc
Copy link
Owner

yamadapc commented Apr 7, 2022

Currently in swift, parameters are classes that combine both the parameter value with its definition (name, range, id). This is problematic, because for effects we need to have some dynamic parameters (since effects will be added into the graph dynamically).

This means we need to first be able to list a "parameter definition/spec" and then create a value which exists on the EntityId graph and corresponds to this instance of the parameter on a certain track and position.

This will require refactoring FloatParameter, IntParameter, etc to keep their declarations separate from their values.

@yamadapc yamadapc added the enhancement New feature or request label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Continuous Looper enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant