Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Stale issues and PRs #11318

Open
2 tasks done
SeventhM opened this issue Mar 16, 2024 · 5 comments
Open
2 tasks done

Re: Stale issues and PRs #11318

SeventhM opened this issue Mar 16, 2024 · 5 comments

Comments

@SeventhM
Copy link
Collaborator

SeventhM commented Mar 16, 2024

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

It seems Yairm added a new GitHub action to label and close older stale Issues and PRs. While I do think there is merit here, I also feel that there likely should be some discussion on some of these to have their labels removed. I'm making this issue here given the large amount of issues that got affected all at once, though perhaps this discussion could take place in each individual issue in the future. I'm also writing this issue because the action made it more difficult to look through issues by recently updated, which is how I usually check for stuff

Issues regarding popular requests or known issues left to solve

Work in progress PRs/Issues

Issues regarding subjects still in discussion

Issues that have been addressed and may need to be moved to a new issue

@SeventhM
Copy link
Collaborator Author

Also, @SomeTroglodyte, You keep talking about redoing the CityScreen. Is that ever going to happen?

@SeventhM
Copy link
Collaborator Author

Updated OP by removing manually closed issues. I'll start marking some of them to not stall, but leave them in the op until addressed so it's easier to come back to if someone wants to address one of them

@touhidurrr
Copy link
Contributor

Thanks for listing stale issues at one place so that others might take a look at them if they looking for something to contribute to.

Recently lot of my issues got marked as stale and I also ignored most of those because the sad truth is if an issue goes stale it simply means there is a lack of interest in that issue and nothing much can be done about it. Attention is a limited resource and more important issues deserves more of it.

Thus I commend your approach of listing stale issues at one place to make it more efficient to look at these issues in future and making sure that stale issues do not get lost into oblivion forever.

@touhidurrr
Copy link
Contributor

touhidurrr commented Mar 30, 2024

Also, this issue that recently got stale caught my attention. Can you have a look at it? It feels like addressing this issue will improve lategame experience and make lategame less boring. #6522 (comment)

@SeventhM
Copy link
Collaborator Author

Also, this issue that recently got stale caught my attention. Can you have a look at it? It feels like addressing this issue will improve lategame experience and make lategame less boring. #6522 (comment)

I kinda have the same viewpoint of Yairm: Someone wants to work on it, sure. If not, I'm not sure it's particularly necessary. Pretty much the ones I saved from being stale are specifically stuff that are clear "should do later" type of stuff with little ambiguity. Here... Not so much imo.

Really, I think it's probably a fine enough thing for singleplayer, but less of a factor in multiplayer. Also, if we're asking for personal opinions, I'd say late game is boring because there's not enough stuff to do that isn't minor usually insignificant micro optimizing, not necessarily that there's too much to do, so I think would be a disagreement on how important something like unit grouping is. Granted, I'm biased as I'm pretty actively involved in another turn based as well, where specific control over every unit does matter, even if it gets boring at times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants