Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor matchier versions... #11

Open
yaauie opened this issue Dec 13, 2013 · 2 comments
Open

Favor matchier versions... #11

yaauie opened this issue Dec 13, 2013 · 2 comments
Assignees

Comments

@yaauie
Copy link
Owner

yaauie commented Dec 13, 2013

Since the current version matcher pattern prettymuch matches numbers in general, let's favor things that match more of the cues (e.g., if it is prefixed with version, or is composed of several parts that are dot-separated).

Please feel free to supply STDOUT and STDERR for your app's --version output, along with the expected match version so I can add tests to ensure.

@dblooman
Copy link

dblooman commented Feb 3, 2015

Just installed version 2.0 of phantomJS, For phantomjs_path = Cliver.detect!('phantomjs', '~> 1.8', '>= 1.8.1')
I get
Cliver::Dependency::VersionMismatch: Could not find an executable 'phantomjs' that matched the requirements '~> 1.8', '>= 1.8.1'. Found versions were {"/usr/local/bin/phantomjs"=>"2.0.0"}.

@yaauie
Copy link
Owner Author

yaauie commented Feb 3, 2015

The ~> 1.8 requirement means "any 1.x that is greater than or equal to 1.8", so unfortunately version 2.0.0 does not satisfy the requirement. It looks like your project will need to be updated with looser requirements in order for cliver to be able to resolve the dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants