Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up type tracking in background #81

Open
jmsull opened this issue Mar 4, 2023 · 0 comments
Open

Clean up type tracking in background #81

jmsull opened this issue Mar 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jmsull
Copy link
Collaborator

jmsull commented Mar 4, 2023

There is no reason for us to enforce that things like the quadrature points/weights should be parameterized as the same type "T" that gets used for the dual. This happens in background.jl, quad_pts, quad_wts and in the ie branch where the splines are used for the iteration. Not sure if it will happen in the updated recfast.jl.
I can't imagine that doing this extra tracking is good for code performance when taking derivatives, though I am not sure how much of a difference it will make.
In any event, this is a quick fix, just putting this here so I don't forget

@jmsull jmsull self-assigned this Mar 4, 2023
@jmsull jmsull added the enhancement New feature or request label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant