Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mixing Enzyme with Rodas via PreallocationTools #695

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

ChrisRackauckas
Copy link
Member

Should fix xzackli/Bolt.jl#59

@ChrisRackauckas ChrisRackauckas merged commit a0d49e3 into master Jul 26, 2022
@ChrisRackauckas ChrisRackauckas deleted the preallocationtools_enzyme branch July 26, 2022 00:23
chunksize::Int
end

EnzymeVJP(; chunksize = 12) = EnzymeVJP(12)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be:

Suggested change
EnzymeVJP(; chunksize = 12) = EnzymeVJP(12)
EnzymeVJP(; chunksize = 12) = EnzymeVJP(chunksize)

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enzyme isn't ready for use with Bolt
2 participants