Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't download some Episodes #3

Closed
MacClelland opened this issue Sep 4, 2023 · 7 comments
Closed

Can't download some Episodes #3

MacClelland opened this issue Sep 4, 2023 · 7 comments

Comments

@MacClelland
Copy link

MacClelland commented Sep 4, 2023

Cant download some episodes. Maybe because there are no subs available.
Examples:
S1 E11
S2 E2
S2 E4
S7 E1
S7 E4
Language is german

I have seen you have fixed this issue, maybe you could rebuild the project with the fixes for Windows. Maybe that helps with downloading these episodes.

@xypwn
Copy link
Owner

xypwn commented Sep 4, 2023

Yup, I've fixed the issue in the source code, as mentioned in xypwn/southpark-de-downloader#11 (comment). Like I said, I don't have access to the SDKs needed to cross-compile all versions since I'm not home at the moment, but I should be able to upload the new binaries in a few hours :)

If you don't want to wait, you can compile it yourself. To do that, simply install Golang and in the source code directory compile with the command go build ./cmd/southpark-downloader-ui (maybe it's go.exe on Windows, I never tried using Go on Win)

@MacClelland
Copy link
Author

MacClelland commented Sep 4, 2023

Installed GO1.21.0 and didnt Work
So I downloaded Go1.18.0 because in the go.mod file it states go1.18

Did that and got error:

# github.com/xypwn/southpark-downloader-ui/internal/gui
..\..\..\internal\gui\episodes.go:150:30: undefined: atomic.Int32
..\..\..\internal\gui\episodes.go:195:32: undefined: atomic.Int32

@xypwn
Copy link
Owner

xypwn commented Sep 4, 2023

1.21 should def work though, go is 100% backwards compatible

@MacClelland
Copy link
Author

With 1.21 im getting this

# runtime/cgo
gcc_libinit_windows.c: In function '_cgo_beginthread':
gcc_libinit_windows.c:143:13: error: implicit declaration of function '_beginthread'; did you mean '_cgo_beginthread'? [-Werror=implicit-function-declaration]
  143 |   thandle = _beginthread(func, 0, arg);
      |             ^~~~~~~~~~~~
      |             _cgo_beginthread
cc1: all warnings being treated as errors

@xypwn
Copy link
Owner

xypwn commented Sep 4, 2023

Oof, that must be a Go error, doesn't look like it's from any code I wrote. You could try 1.20, but if that doesn't work I guess you'll just have to wait a bit.

@xypwn
Copy link
Owner

xypwn commented Sep 4, 2023

I just found this issue that mentions your exact error, seems to be pretty common with golang on Windows

golang/go#59490 (comment)

@MacClelland
Copy link
Author

Damn. that did the trick. compiled instantly.
And downloading these episodes works now. Thx for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants