Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The trusted domains configuration option does not seem to work properly #56

Closed
aubincleme opened this issue Jan 24, 2024 · 1 comment
Closed

Comments

@aubincleme
Copy link
Member

aubincleme commented Jan 24, 2024

Steps to reproduce : 

  • Install the PDF viewer application 2.5.3 on XWiki 15.10.x,
  • Add the following macro in one of the pages :
{{pdfviewer file="https://www.dfn.de/wp-content/uploads/2021/12/satzungdfn.pdf"/}}

image

@trrenty
Copy link

trrenty commented Apr 3, 2024

Hello, @aubincleme . The list of trusted domains in the PDF Macro configuration refer to the viewer domains, which, in most cases, means the domain of the xwiki server.

After reviewing this issue and #57 (where you used a bad example taken from the documentation) I also got to realise how lacking the documentation of this app is.

Will close this issue as invalid and update the documentation as per #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants