Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs/typo in noise.py #21

Open
deep07004 opened this issue Aug 18, 2022 · 2 comments
Open

bugs/typo in noise.py #21

deep07004 opened this issue Aug 18, 2022 · 2 comments

Comments

@deep07004
Copy link

Line no 516: Indx = np.where(cc_comp==comp)[0]
It is not working as cc_comp is a list.
Line no 613: dstack[i,:] = stack.seisstack(cc_array,method=method,par=par)
method is a list here, but seisstack is expecting a string.
Moreover, In the function do_stacking, there is conflict between variable 'rotation' and function call to 'rotation'.

Note: This is the first time I am reporting any issue on this platform. So please accept my apology in advance if this is not the correct way of presenting.

@xtyangpsp
Copy link
Owner

Thanks for reporting the issue. I apologize for this late reply. do_stacking is an old function that has some issues in managing/organizing the correlation data (after stacking). There is a new function that would serve a better and more consistent and simple way to stacking data. The function is: merge_pairs(), in noise.py module. I have updated seisstack to accept both string and string list.

@xtyangpsp
Copy link
Owner

The function merge_pair() doesn't have the option of rotating the components. Please welcome to submit your issues and edits/fixs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants