Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text rendering is a little blurry still #985

Closed
Tyriar opened this issue Sep 13, 2017 · 8 comments
Closed

Text rendering is a little blurry still #985

Tyriar opened this issue Sep 13, 2017 · 8 comments
Assignees
Labels
type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 13, 2017

Notice "daniel" gets blurry a few rows down when compared to rows above. Changing the canvas height from 500 -> 501 seems to fix it so it's probably a problem with the IRenderDimensions generation.

image

@Tyriar Tyriar added the type/bug Something is misbehaving label Sep 13, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Sep 13, 2017
@Tyriar Tyriar self-assigned this Sep 13, 2017
@vincentwoo
Copy link
Contributor

Should this issue be closed now?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 4, 2017

I can still see a little blurriness when zooming in, I think the calculation may be 1-2 pixels off when devicePixelRatio is a decimal.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 8, 2018

I think this might be fixed, if not it will come up again 😄

@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2018

Just got a report for this: microsoft/vscode#55701

@Tyriar Tyriar reopened this Aug 3, 2018
@saulcosta
Copy link
Contributor

We are also experiencing this issue. Is there a fix planned, or are there any workarounds for the time being?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2019

I can't repro this anymore, if you still see it please create a new issue with repro details.

@Tyriar Tyriar closed this as completed Oct 7, 2019
@usernamehw
Copy link

In vscode it gets blurry a lot after resizing

"window.zoomLevel": 1, 
"terminal.integrated.fontSize": 16,

The app is running with arguments, some of them: --disable-smooth-scrolling --force-color-profile=srgb

Workaround that works for me is to use a dom renderer:

"terminal.integrated.rendererType": "dom",

@Tyriar
Copy link
Member Author

Tyriar commented Jan 2, 2020

@usernamehw created #2662 with an idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

4 participants