Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savitzky Golay filter implementation #6

Closed
wants to merge 1 commit into from

Conversation

spectre-ns
Copy link
Collaborator

@JohanMabille I wanted to submit this to get your feedback.

I tested that the outputs are identical to within numerical error of Python so I know the math is correct. I'm not clear on if I should be trying to build expressions to represent the algorithms or do as I'm doing and directly evaluate them. I need to add documentation to these as well. What is the preferred documentation tool?

I Implemented it using a Toeplitz matrix rather than a convolution because it can be multithreaded in the future where direct convolutions cannot be easily. Currently it is likely slower than a single threaded direct convolution but faster than direct evaluation of polynomial fit solving using least squares as would be required in the direct evaluation of the SG filter. Need to benchmark at some point. Likely a different PR.

This PR resolves #1

Thanks for any and all feedback!

@spectre-ns
Copy link
Collaborator Author

Cleaning some stuff up closing see next PR.

@spectre-ns spectre-ns closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Savitzky–Golay filter
2 participants