Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_gamma_test fails on macOS #807

Closed
sifmelcara opened this issue Aug 23, 2022 · 5 comments
Closed

error_gamma_test fails on macOS #807

sifmelcara opened this issue Aug 23, 2022 · 5 comments

Comments

@sifmelcara
Copy link

sifmelcara commented Aug 23, 2022

Hello, I'm packaging xsimd 8.1.0 in Nix package manager (NixOS/nixpkgs#187380), and our CI indicate that both M1 and Intel Mac has 1 test case failed (but they failed on different test case)

aarch64: link to CI log

[ RUN      ] error_gamma_test/arm_double.gamma
/tmp/nix-build-xsimd-8.1.0.drv-0/source/test/test_error_gamma.cpp:144: Failure
Expected equality of these values:
  diff
    Which is: 5
  0
  while testing lgamma (negative input)
[  FAILED  ] error_gamma_test/arm_double.gamma, where TypeParam = xsimd::batch<double, xsimd::neon64> (3 ms)

x86_64: link to CI log

[ RUN      ] error_gamma_test/fallback_double.gamma
/tmp/nix-build-xsimd-8.1.0.drv-0/source/test/test_error_gamma.cpp:144: Failure
Expected equality of these values:
  diff
    Which is: 3
  0
  while testing lgamma (negative input)
[  FAILED  ] error_gamma_test/fallback_double.gamma, where TypeParam = xsimd::batch<double, xsimd::sse4_1> (6 ms)

Do you have any idea? Thank you!

@sifmelcara
Copy link
Author

Oh, I just noticed that previous person who packaged xsimd in our package manager already disabled "error_gamma_test/sse_double.gamma" test and "error_gamma_test/avx_double.gamma" test due to #456

Could this be a similar issue?

@SomeoneSerge
Copy link

Have there been any updates on this issue in xsimd 10/11?

@doronbehar
Copy link
Contributor

Hello Nixers. xsimd update to 11.1.0 happens in NixOS/nixpkgs#246200 .

@serge-sans-paille
Copy link
Contributor

I believe #1024 finally fixes it.

@doronbehar
Copy link
Contributor

I will fetch #1024 into nixpkgs, but I won't wait for CI this time. Thanks @serge-sans-paille for your help and communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants