Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated options #90

Open
anthony-steele-cko opened this issue Aug 12, 2020 · 2 comments · May be fixed by #194
Open

Deprecated options #90

anthony-steele-cko opened this issue Aug 12, 2020 · 2 comments · May be fixed by #194

Comments

@anthony-steele-cko
Copy link

Note the output of the run, some deprecated options of dotnet-format are used:

Run xt0rted/dotnet-format@v1
Checking 7 files
/usr/bin/dotnet format --check --dry-run --files _somefiles_
  The `--files` option is deprecated. Use the `--include` option instead.
  The `--dry-run` option is deprecated. Use the `--check` option instead.
@mikeage
Copy link

mikeage commented Mar 30, 2021

As of Feb 11th[1], this is now broken, no longer just deprecated

[1] https://github.com/dotnet/format/releases/tag/v5.0.211103

mikeage added a commit to mikeage/open-brush that referenced this issue Mar 30, 2021
@mikeage
Use older version of dotnet format because of xt0rted/dotnet-format#90
4c7f2a6
@xt0rted xt0rted linked a pull request Apr 27, 2021 that will close this issue
Draft
@williamhammond
Copy link

I believe I've run into this. This completely breaks the check option right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for dotnet-format v4 xt0rted/dotnet-format
3 participants
@mikeage @williamhammond @anthony-steele-cko