Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where Tracker._init_io_buffer set buffer to None #496

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix bug where Tracker._init_io_buffer set buffer to None #496

merged 1 commit into from
May 21, 2024

Conversation

szymonlopaciuk
Copy link
Collaborator

Description

Fix a bug where Tracker._init_io_buffer would set the tracker's io_buffer to None.

Closes xsuite/xsuite#502.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@giadarol giadarol changed the base branch from main to merge/radiation_in_matrix May 21, 2024 20:51
@giadarol giadarol merged commit 63e6f21 into xsuite:merge/radiation_in_matrix May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giadarol giadarol giadarol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracker._init_io_buffer outputs None instead of a valid buffer
2 participants
@szymonlopaciuk @giadarol