Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor an optional parameter on TSpellInstructions #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahmoud
Copy link
Contributor

@mahmoud mahmoud commented Oct 25, 2023

Fixes #77

@youmustfight
Copy link
Member

Thanks! This is likely fine, I just want to make sure this won't blow up the no-code editor package spellbook. The editor object holds some meta info like a title, internal note, and change history at these files:

Spellbook's top bar with title note:
https://github.com/xstate-wizards/xstate-wizards/blob/main/packages/spellbook/src/components/SpellMetaEditor.tsx#L59

Spellbook's sidebar with change history user/date:
https://github.com/xstate-wizards/xstate-wizards/blob/main/packages/spellbook/src/components/stateEditors/SpellStateHistory.tsx#L10

@mahmoud
Copy link
Contributor Author

mahmoud commented Nov 3, 2023

Cool, for what it's worth, I've been using the spellbook example as a no-code editor with my change (and a few others) and it's been cruising :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor is required in TSpellInstructions, but missing in exampleScreener.ts
2 participants