Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor is required in TSpellInstructions, but missing in exampleScreener.ts #77

Open
mahmoud opened this issue Oct 25, 2023 · 1 comment · May be fixed by #81
Open

editor is required in TSpellInstructions, but missing in exampleScreener.ts #77

mahmoud opened this issue Oct 25, 2023 · 1 comment · May be fixed by #81

Comments

@mahmoud
Copy link
Contributor

mahmoud commented Oct 25, 2023

My entire exampleScreener.ts is red (in vanilla VSCode, see screenshot below).

Argument of type '{ key: string; version: string; config: { initial: string; title: string; exitTo: string; sectionsBar: never[]; }; models: { User: { loader: {}; }; }; schema: { type: "object"; properties: { states: { type: "object"; properties: { ...; }; }; }; }; states: { ...; }; }' is not assignable to parameter of type 'TSpellInstructions'.
  Property 'editor' is missing in type '{ key: string; version: string; config: { initial: string; title: string; exitTo: string; sectionsBar: never[]; }; models: { User: { loader: {}; }; }; schema: { type: "object"; properties: { states: { type: "object"; properties: { ...; }; }; }; }; states: { ...; }; }' but required in type 'TSpellInstructions'.ts(2345)
types.d.ts(221, 5): 'editor' is declared here.

I guess I'm wondering, is editor required? Or should it be optional?

Screenshot from 2023-10-24 22-49-34

@youmustfight
Copy link
Member

youmustfight commented Oct 25, 2023

Definitely optional. Have been meaning to tighten up the typings a bit, but especially that one 😅 the editor object is for the no-code interface, storing things like a user change edit history/log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants