Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install demo friction (2023-10-24) #75

Open
mahmoud opened this issue Oct 25, 2023 · 2 comments
Open

Fresh install demo friction (2023-10-24) #75

mahmoud opened this issue Oct 25, 2023 · 2 comments

Comments

@mahmoud
Copy link
Contributor

mahmoud commented Oct 25, 2023

Hey again! So, in my spare time I've been coming up to speed on xstate-wizards.

I got the main screener+interview demo running, but I hit a couple speedbumps on the way. I'm just going to list them off for confirmation these aren't intended behavior or issues due to my environment (Ubuntu 22.04, node 16.15, Chromium 118):

  1. Several internal packages were out-of-date from one another, resulting in the pages rendering without fully loading styles, and crystal ball wasn't loading at all.
    • Errors of the form: @xstate-wizards/spellbook has a dependency on @xstate-wizards/wizards-of-react@^0.7.2 but the version of @xstate-wizards/wizards-of-react in the repo is 0.8.5 which is not within range of the depended on version, please update the dependency version.
    • Fix was to bump three internal package.json dependency versions to match the other packages' versions, then rebuild and re-yalcpush.
  2. I had to yarn add react-player for examples/react-wizards
    • Seems like it should be a transitive dependency from wizards-of-react's ContentNode. I see it referenced a few places, but no idea why it wasn't getting installed. (I had some ENOENT error.)

Happy to put my fixes in a PR, but I figure if you can reproduce, you can probably just commit the fixes.

@mahmoud
Copy link
Contributor Author

mahmoud commented Oct 25, 2023

Pretty sure 2 above is actually this: wclr/yalc#213

Yalc linking doesn't do transitive dependencies, so I keep having to rebuild and reinstall when making changes. Unless there's a trick I'm missing?

@youmustfight
Copy link
Member

Thanks for the heads up! Whenever I make a change in one of the packages, at the top level I then type/run the command npm run yalcpush which triggers the lerna command to run through all the packages so updates ripple through everything locally. I'm curious how other libraries do local dev setup when there is a tree of package dependencies, but I've found this to be convenient once it's setup (also, will be able to tackle more of these in ~2 weeks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants