Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likelihood does not support Everywhere #378

Open
thjsal opened this issue Apr 26, 2024 · 0 comments · May be fixed by #381
Open

Likelihood does not support Everywhere #378

thjsal opened this issue Apr 26, 2024 · 0 comments · May be fixed by #381
Assignees
@thjsal
Labels
bug Something isn't working

Comments

@thjsal
Copy link
Contributor

thjsal commented Apr 26, 2024

Calculating likelihoods using Everywhere model does not work without customizing the Likelihood class. This is because HotRegions are referenced there in a couple of places (e.g. here

xpsi/xpsi/Likelihood.py

Line 116 in 31852f0

signal.phases = photosphere.hot.phases_in_cycles
). But it should be possible to make likelihood calculation independent of the surface radiation model.
@thjsal thjsal added the bug Something isn't working label Apr 26, 2024
@thjsal thjsal self-assigned this Apr 26, 2024
@thjsal thjsal changed the title Likelihood does not support Everwhere Likelihood does not support Everywhere Apr 26, 2024
@thjsal thjsal linked a pull request Apr 26, 2024 that will close this issue
Allow Everywhere for standard Likelihood #381
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thjsal thjsal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Everywhere for standard Likelihood xpsi-group/xpsi
1 participant
@thjsal