New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Everywhere for standard Likelihood #381
base: main
Are you sure you want to change the base?
Conversation
The default imaging extension has been changed from ``uniform.pyx`` to ``PDT_U.pyx`` to avoid the need for X-PSI re-installation when computing neutron star images for different nested models. The tutorials have been updated to account for this change when necessary. Some bugs in the imaging function were also fixed, and the Global surface emission -tutorial was added back to the documentation pages.
I just noticed that for some modules we have used this update produces this error: I don't know why this occurs only for some of the tests (e.g. |
I found that the issue occured always when having multiple signal objects.I fixed it by changing |
Co-authored-by: Yves Kini <kiniyves@gmail.com> Co-authored-by: Ylvie Gerritsma <ylviegerritsma@icloud.com>
Now I also modified the code so that Everywhere class will always create and fix this additional phase_shift parameter to zero without any customization from the user. |
Likelihood.py modified so that it can be used for both HotRegion and Everywhere objects without user customization. In case of Everwhere, however, one needs to make a CustomEverywhere where an extra
phase_shift
parameter is added like this (EDIT: THIS IS NOT NEEDED ANYMORE):This parameter can be fixed to zero when creating an Everywhere instance:
This is to avoid having extra if or try statement in the likelihood evaluation slowing the inference runs (an option disfavored by @yveskini), but still being able to use the same Likelihood syntax for both HotRegions and Everywhere.
We can add phase_shift to be also part of Everywhere class by default, but maybe it is not needed, since for usual applications that class is customized anyway?