Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cython crash in a clean way (or catch the errors) when atmosphere extensions are wrong #325

Open
sguillot opened this issue Sep 8, 2023 · 0 comments
Open

Make Cython crash in a clean way (or catch the errors) when atmosphere extensions are wrong #325

sguillot opened this issue Sep 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sguillot
Copy link
Contributor

sguillot commented Sep 8, 2023

Currently a wrong atmosphere extension (different than 1, 2, or 3) will default to blackbody (=1) with a warning to the user. This warning may go unnoticed by the user, and it would be preferable to have a clean crash or an error catching.

Nonetheless, there are checks being done before that should ensure than no values different than 1, 2 or 3 are passed to the atmosphere cython extensions.
@sguillot sguillot added the enhancement New feature or request label Sep 8, 2023
@sguillot sguillot changed the title Make Cython crash in a clean way (or catch the errors) when atmosphere extension are wrong Make Cython crash in a clean way (or catch the errors) when atmosphere extensions are wrong Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sguillot