Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotRegion.set_num_cells reverts to default values for arguments not passed #307

Open
DevarshiChoudhury opened this issue May 17, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@DevarshiChoudhury
Copy link
Member

DevarshiChoudhury commented May 17, 2023

self.set_num_cells(sqrt_num_cells,

Based on the Hot Region Complexity notebook (input prompt 16 & 18), the expected behaviour of set_num_cells is to set specific cell resolution arguments manually and then run star.update, to update only the arguments passed and not others. Currently, the way the function is defined, it updates the arguments passed, but for other arguments that the function takes, it reverts to the default values instead of retaining the original user-defined values.

Solution would be to either update the doc to clarify this or improve the code to only update the argument passed. The latter is preferable so that the user doesn't have to restart the program just to update certain parameters.

P.S. set_num_rays and set_phases don't have any default arguments. It's yet to be investigated how they behave if only updating some of the arguments.

@DevarshiChoudhury DevarshiChoudhury added bug Something isn't working enhancement New feature or request labels May 17, 2023
@DevarshiChoudhury DevarshiChoudhury changed the title HotRegion.set_num_cells reverts to default values for arguments not passed `HotRegion.set_num_cells` reverts to default values for arguments not passed May 17, 2023
@DevarshiChoudhury DevarshiChoudhury changed the title `HotRegion.set_num_cells` reverts to default values for arguments not passed HotRegion.set_num_cells reverts to default values for arguments not passed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant