Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change is_secondary in Hot_region_complexity #291

Open
daspushpita opened this issue Feb 17, 2023 · 4 comments
Open

Change is_secondary in Hot_region_complexity #291

daspushpita opened this issue Feb 17, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@daspushpita
Copy link
Contributor

https://github.com/xpsi-group/xpsi/blob/ace8ec39e2ed7f59bd84ce99ec2014b9121abfe8/docs/source/Hot_region_complexity.ipynb

@thjsal
Copy link
Contributor

thjsal commented Feb 17, 2023

And what is the reason it needs to be changed? From True to False, I guess?

@daspushpita
Copy link
Contributor Author

daspushpita commented Feb 17, 2023

I think True sets the bounds from 0 to 2pi. But It is deprecated I guess?

@thjsal
Copy link
Contributor

thjsal commented Mar 9, 2023

I don't think it is deprecated yet. I thought it just that we want to deprecate it.

@thjsal
Copy link
Contributor

thjsal commented Mar 9, 2023

Okay, I see in the comment string (in HotRegion.py) that this is_secondary is indeed deprecated in the sense that it has exactly the same effect as if using is_antiphased keyword argument. But it principle, it should still work as it is meant to work, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants