Compiling on macOS fails #3
Comments
|
Same, I've tried with the bundled MacOS llvm as well as the latest. |
|
Pull #6 fixes one of these errors. Changing <ucontext.h> to <sys/ucontext.h> fixes another. Changing uc->mcontext.gregs to uc->mcontext->gregs fixed another. Unfortunately, there's no ->gregs member in uc_mcontext64 on Darwin: Because, apparently, this is dependent on glibc's register reading stuff: https://fossies.org/dox/glibc-2.25/structmcontext__t.html This ancient article talks about trying to persuade an old OS X kernel to divulge register state: Ideally there's a better way these days, but no guarantee there. |
|
Happily, ->mcontext64->__ss is nothing but registers: |
Variations of this seem to, at the very least, remove more warnings. Still doesn't compile and I'd be surprised if a straight swap out here worked. |
|
cpu_set_t is GNU-only: https://www.gnu.org/software/libc/manual/html_node/CPU-Affinity.html You can fake the goal here, which is I believe to test one core only, using: http://jesperrasmussen.com/2013/03/07/limiting-cpu-cores-on-the-fly-in-os-x/ Storing and restoring __ss might be as simple as using plain struct assignment: And then there's this: |
|
Which I tried to resolve with 'static dummy', and then managed to get: cc -c injector.c -o injector.o -Wall So we're making progress! But this is where I run out of gas, because I can't debug assembler 32/64 differences, sorry. |
|
So it seems the issues we are facing for macOS deal with the XNU kernel architecture as a whole.
So in general this code will work, but will need a specific branch for any MACH based micro kernel. |
|
So I am working on CPU_SET, and it seems all the functions needed can be called from the Affinity API (According to http://yyshen.github.io/2015/01/18/binding_threads_to_cores_osx.html) So far the first code block works fine, and compiles with no errors. Also with these code blocks in, the current CPU_SET errors go away, but... this code block needs rewritten it seems. `int pthread_setaffinity_np(pthread_t thread, size_t cpu_size, }` @floatingatoll Would you be able to debug this code? I unfortunately do not know enough C to try. These are the errors I get:
It says Leopard, but it is still supported and used in the current macOS (Including 10.13) |
|
Sorry, I haven't the foggiest how to *write* C code. It looks like you need
to start with solving this, though:
error: use of undeclared identifier 'thread_affinity_policy_data_t'
Since providing the right header here should fix many of these errors.
- R.
…On Wed, Aug 2, 2017 at 6:08 PM, IComplainInComments < ***@***.***> wrote:
So I am working on CPU_SET, and it seems all the functions needed can be
called from the Affinity API (According to http://yyshen.github.io/2015/
01/18/binding_threads_to_cores_osx.html)
So far the first code block works fine, and compiles with no errors. Also
with these code blocks in, the current CPU_SET errors go away, but... this
code block needs rewritten it seems.
`int pthread_setaffinity_np(pthread_t thread, size_t cpu_size,
cpu_set_t *cpu_set)
{
pthread_cond_t mach_thread;
int core = 0;
for (core = 0; core < 8 * cpu_size; core++) {
if (CPU_ISSET(core, cpu_set)) break;
}
printf("binding to core %d\n", core);
thread_affinity_policy_data_t policy = { core };
mach_thread = pthread_mach_thread_np(thread);
thread_policy_set(mach_thread, THREAD_AFFINITY_POLICY,
(thread_policy_set)&policy, 1);
return 0;
}
`
@floatingatoll <https://github.com/floatingatoll> would you possibly be
able to rewrite this code to compile? Im getting these errors:
injector.c:1383:5: error: use of undeclared identifier
'thread_affinity_policy_data_t' thread_affinity_policy_data_t policy = {
core }; ^ injector.c:1384:17: error: assigning to 'pthread_cond_t' (aka
'struct _opaque_pthread_cond_t') from incompatible type 'mach_port_t' (aka
'unsigned int') mach_thread = pthread_mach_thread_np(thread); ^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ injector.c:1385:5: warning: implicit
declaration of function 'thread_policy_set' is invalid in C99
[-Wimplicit-function-declaration] thread_policy_set(mach_thread,
THREAD_AFFINITY_POLICY, ^ injector.c:1386:43: error: use of undeclared
identifier 'policy' (thread_policy_set)&policy, 1); ^ injector.c:1385:36:
error: use of undeclared identifier 'THREAD_AFFINITY_POLICY'
thread_policy_set(mach_thread, THREAD_AFFINITY_POLICY, ^ injector.c:1396:7:
warning: implicit declaration of function 'sched_setaffinity' is invalid in
C99 [-Wimplicit-function-declaration] if (sched_setaffinity(0,
sizeof(mask), &mask)) {
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFqDHX31KAXo6yiHCadvBTPJq7HdkYFks5sUR2mgaJpZM4OmW_m>
.
|
|
Alright it seems like adding There are now just 8 total errors that need hammered out. The new Errors go as follows: and
|
|
Found a fix, delete this code block: ` thread_policy_set(mach_thread, THREAD_AFFINITY_POLICY, 6 Errors left! So all we need to do now is figuring out how to get the Program to use Pthread from the kernel! |
|
Also stuck at :/ |
|
There might be a hint here:
rust-lang/rust#41337
The operand for the "i" constraint must be constant, so in general this
won't work.
I have an asm fix earlier in the thread that might help you here.
…On Wed, Aug 2, 2017 at 10:06 PM, IComplainInComments < ***@***.***> wrote:
Also stuck at injector.c:818:24: error: invalid operand for inline asm
constraint 'i' __asm__ __volatile__ ("\ ^
:/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFqDJxPNrDwGrf3OexdnB1yc1OFB5qDks5sUVVCgaJpZM4OmW_m>
.
|
|
I got this to compile, but I'm not sure if the executable still works as intended. Change 1: Dummy StructModify the following snippet: Lines 174 to 177 in 8375e61 Delete the entire dummy_stack definition. Then, copy the following (to anywhere before the inject_state typedef struct definition on line 90!):
typedef struct {
uint64_t dummy_stack_hi[256];
uint64_t dummy_stack_lo[256];
} dumb_stack;
static dumb_stack dummy_stack __attribute__ ((aligned(PAGE_SIZE)));Then, in the ...
uint64_t rsp;
dumb_stack dumb;
} state_t;
...and the ...
.rsp=0,
.dumb.dummy_stack_lo=0,
.dumb.dummy_stack_hi=0
};
...We also need to modify the stack reset on line 766: inject_state.dumb.dummy_stack_lo[0]=0;And lastly, we need to modify the inline asm here: Lines 777 to 815 in 8375e61 The asm on line 813 should read: Change 2:
|
|
@jaketesler Thanks for writing the missing C code we needed! I really should brush up on my coding hehe |
On macOS
makeyeilds:Using
or
fixes the first issue. But, it looks like there is still an issue with the portability of ucontext structures:
The text was updated successfully, but these errors were encountered: